Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add generic connected hook #92

Merged
merged 5 commits into from
Dec 5, 2024
Merged

Conversation

dpanta94
Copy link
Member

@dpanta94 dpanta94 commented Dec 5, 2024

Similar to #87

but here adding:

generic connect hook
specific and generic disconnect hooks
tests :D

@dpanta94 dpanta94 self-assigned this Dec 5, 2024
@dpanta94 dpanta94 added the enhancement New feature or request label Dec 5, 2024
@rafsuntaskin
Copy link

@dpanta94 @since tags needs to be updated. Other than that looking good 💯

@dpanta94 dpanta94 marked this pull request as ready for review December 5, 2024 19:06
@dpanta94 dpanta94 requested review from defunctl and borkweb December 5, 2024 19:06
Copy link
Member

@borkweb borkweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great addition!

@dpanta94 dpanta94 merged commit 5bc1f11 into main Dec 5, 2024
13 checks passed
@dpanta94 dpanta94 deleted the feat/add-generic-connected-hook branch December 5, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants